WIP

Not sure whether I like this change or not... IMO this might be too lax.

grammar.js

@@ -19,7 +19,7 @@ module.exports = grammar({
       $.module,
     ),
 
-    line_comment: (_) => seq("//", /.*/),
+    line_comment: (_) => seq("//", /[^\n]*/),
 
     block_comment: (_) => seq("/*", /[^*]*\*+([^/*][^*]*\*+)*/, '/'),
 

queries/highlights.scm

@@ -42,11 +42,11 @@
 (identifier) @variable
 
 (module
-  type: (identifier) @module)
+  type: (identifier) @function.call)
 
 (module
   (property
-    field: (identifier) @variable.member))
+    field: (identifier) @variable.parameter))
 ; }}}
 
 ; Built-ins {{{

src/grammar.json

@@ -30,7 +30,7 @@
         },
         {
           "type": "PATTERN",
-          "value": ".*"
+          "value": "[^\\n]*"
         }
       ]
     },

test/corpus/comments.txt

@@ -85,6 +85,23 @@ Block comment with asterisks
 
 --------------------------------------------------------------------------------
 
+(source_file
+  (block_comment))
+
+================================================================================
+Block comment (multiline)
+================================================================================
+
+/*
+    This
+    is
+    a
+    long
+    comment
+*/
+
+--------------------------------------------------------------------------------
+
 (source_file
   (block_comment))
 

test/highlight/builtins.bp

@@ -2,13 +2,7 @@ foo = select(soong_config_variable("my_namespace", "my_var"), {
     //       ^ function.builtin
     "foo": unset,
     //     ^ variable.builtin
-    default: select(variant("VARIANT") {}),
+    default: select(variant("VARIANT"), {}),
     // <- variable.builtin
     //              ^ function.builtin
 })
-
-/* Assigning to builtins is conveniently not allowed at runtime */
-unset = 12
-// <- variable.builtin
-default = 27
-// <- variable.builtin

test/highlight/modules.bp

@@ -1,21 +1,21 @@
 foo {}
-// <- module
+// <- function.call
 
 foo ()
-// <- module
+// <- function.call
 
 foo {
-// <- module
+// <- function.call
     field: 12,
-    // <- variable.member
+    // <- variable.parameter
     another_field: 27,
-    // <- variable.member
+    // <- variable.parameter
 }
 
 foo (
-// <- module
+// <- function.call
     field = 42,
-    // <- variable.member
+    // <- variable.parameter
     done = false,
-    // <- variable.member
+    // <- variable.parameter
 )

test/highlight/properties.bp

@@ -1,6 +1,6 @@
 foo {
     field: {
-    // <- variable.member
+    // <- variable.parameter
         key: 42,
         // <- property
     },

test/highlight/select.bp

@@ -11,5 +11,5 @@ select = 42
 // Or module property
 foo {
     select: 42,
-    // <- variable.member
+    // <- variable.parameter
 }