diff --git a/grammar.js b/grammar.js index 78659be..997674c 100644 --- a/grammar.js +++ b/grammar.js @@ -19,7 +19,7 @@ module.exports = grammar({ $.module, ), - line_comment: (_) => seq("//", /.*/), + line_comment: (_) => seq("//", /[^\n]*/), block_comment: (_) => seq("/*", /[^*]*\*+([^/*][^*]*\*+)*/, '/'), diff --git a/queries/highlights.scm b/queries/highlights.scm index 124c334..9506ebd 100644 --- a/queries/highlights.scm +++ b/queries/highlights.scm @@ -42,11 +42,11 @@ (identifier) @variable (module - type: (identifier) @module) + type: (identifier) @function.call) (module (property - field: (identifier) @variable.member)) + field: (identifier) @variable.parameter)) ; }}} ; Built-ins {{{ diff --git a/src/grammar.json b/src/grammar.json index 1dc5a08..06f61d9 100644 --- a/src/grammar.json +++ b/src/grammar.json @@ -30,7 +30,7 @@ }, { "type": "PATTERN", - "value": ".*" + "value": "[^\\n]*" } ] }, diff --git a/test/corpus/comments.txt b/test/corpus/comments.txt index 5304a7e..6c91a89 100644 --- a/test/corpus/comments.txt +++ b/test/corpus/comments.txt @@ -85,6 +85,23 @@ Block comment with asterisks -------------------------------------------------------------------------------- +(source_file + (block_comment)) + +================================================================================ +Block comment (multiline) +================================================================================ + +/* + This + is + a + long + comment +*/ + +-------------------------------------------------------------------------------- + (source_file (block_comment)) diff --git a/test/highlight/builtins.bp b/test/highlight/builtins.bp index 508a8ed..73b32e3 100644 --- a/test/highlight/builtins.bp +++ b/test/highlight/builtins.bp @@ -2,13 +2,7 @@ foo = select(soong_config_variable("my_namespace", "my_var"), { // ^ function.builtin "foo": unset, // ^ variable.builtin - default: select(variant("VARIANT") {}), + default: select(variant("VARIANT"), {}), // <- variable.builtin // ^ function.builtin }) - -/* Assigning to builtins is conveniently not allowed at runtime */ -unset = 12 -// <- variable.builtin -default = 27 -// <- variable.builtin diff --git a/test/highlight/modules.bp b/test/highlight/modules.bp index 248acdf..e115e6a 100644 --- a/test/highlight/modules.bp +++ b/test/highlight/modules.bp @@ -1,21 +1,21 @@ foo {} -// <- module +// <- function.call foo () -// <- module +// <- function.call foo { -// <- module +// <- function.call field: 12, - // <- variable.member + // <- variable.parameter another_field: 27, - // <- variable.member + // <- variable.parameter } foo ( -// <- module +// <- function.call field = 42, - // <- variable.member + // <- variable.parameter done = false, - // <- variable.member + // <- variable.parameter ) diff --git a/test/highlight/properties.bp b/test/highlight/properties.bp index 6bc97ef..8ad2c55 100644 --- a/test/highlight/properties.bp +++ b/test/highlight/properties.bp @@ -1,6 +1,6 @@ foo { field: { - // <- variable.member + // <- variable.parameter key: 42, // <- property }, diff --git a/test/highlight/select.bp b/test/highlight/select.bp index 831608d..b857c1e 100644 --- a/test/highlight/select.bp +++ b/test/highlight/select.bp @@ -11,5 +11,5 @@ select = 42 // Or module property foo { select: 42, - // <- variable.member + // <- variable.parameter }