Merge soong_config_variable into select_value
Some checks failed
ci/woodpecker/push/check Pipeline failed

It makes the parse tree easier to use, and I don't think we need to care
for the lax parsing.
This commit is contained in:
Bruno BELANYI 2024-04-14 13:11:37 +01:00
parent f283c14865
commit e9632a29ba
5 changed files with 956 additions and 1000 deletions

View file

@ -6,6 +6,15 @@ function trailingCommaSeparated(elem) {
return repeat(seq(elem, ","))
}
const SELECTION_TYPES = [
// One argument
"product_variable",
"release_variable",
"variant",
// Two arguments
"soong_config_variable",
]
module.exports = grammar({
name: "bp",
@ -121,35 +130,17 @@ module.exports = grammar({
select_expression: ($) => seq(
"select",
"(",
choice($.select_value, $.soong_config_variable),
$.select_value,
",",
$._select_cases,
")",
),
// FIXME: simplify with 'soong_config_variable'?
// Allow for some incorrect usage, to make the parse tree simpler
select_value: ($) => seq(
field("type", alias(
choice("product_variable", "release_variable", "variant"),
$.selection_type,
)),
field("type", alias(choice(...SELECTION_TYPES), $.selection_type)),
"(",
field("condition", $._string_literal),
")",
),
// FIXME
soong_config_variable: ($) => seq(
field("type", alias("soong_config_variable", $.selection_type)),
"(",
field(
"condition",
seq(
field("namespace", $._string_literal),
",",
field("variable", $._string_literal),
),
),
field("condition", commaSeparated($._string_literal)),
")",
),

91
src/grammar.json generated
View file

@ -469,17 +469,8 @@
"value": "("
},
{
"type": "CHOICE",
"members": [
{
"type": "SYMBOL",
"name": "select_value"
},
{
"type": "SYMBOL",
"name": "soong_config_variable"
}
]
"type": "SYMBOL",
"name": "select_value"
},
{
"type": "STRING",
@ -517,6 +508,10 @@
{
"type": "STRING",
"value": "variant"
},
{
"type": "STRING",
"value": "soong_config_variable"
}
]
},
@ -528,40 +523,6 @@
"type": "STRING",
"value": "("
},
{
"type": "FIELD",
"name": "condition",
"content": {
"type": "SYMBOL",
"name": "_string_literal"
}
},
{
"type": "STRING",
"value": ")"
}
]
},
"soong_config_variable": {
"type": "SEQ",
"members": [
{
"type": "FIELD",
"name": "type",
"content": {
"type": "ALIAS",
"content": {
"type": "STRING",
"value": "soong_config_variable"
},
"named": true,
"value": "selection_type"
}
},
{
"type": "STRING",
"value": "("
},
{
"type": "FIELD",
"name": "condition",
@ -569,24 +530,36 @@
"type": "SEQ",
"members": [
{
"type": "FIELD",
"name": "namespace",
"type": "SYMBOL",
"name": "_string_literal"
},
{
"type": "REPEAT",
"content": {
"type": "SYMBOL",
"name": "_string_literal"
"type": "SEQ",
"members": [
{
"type": "STRING",
"value": ","
},
{
"type": "SYMBOL",
"name": "_string_literal"
}
]
}
},
{
"type": "STRING",
"value": ","
},
{
"type": "FIELD",
"name": "variable",
"content": {
"type": "SYMBOL",
"name": "_string_literal"
}
"type": "CHOICE",
"members": [
{
"type": "STRING",
"value": ","
},
{
"type": "BLANK"
}
]
}
]
}

58
src/node-types.json generated
View file

@ -430,10 +430,6 @@
{
"type": "select_value",
"named": true
},
{
"type": "soong_config_variable",
"named": true
}
]
}
@ -443,49 +439,13 @@
"named": true,
"fields": {
"condition": {
"multiple": false,
"required": true,
"types": [
{
"type": "interpreted_string_literal",
"named": true
},
{
"type": "raw_string_literal",
"named": true
}
]
},
"type": {
"multiple": false,
"required": true,
"types": [
{
"type": "selection_type",
"named": true
}
]
}
}
},
{
"type": "soong_config_variable",
"named": true,
"fields": {
"condition": {
"multiple": false,
"multiple": true,
"required": true,
"types": [
{
"type": ",",
"named": false
}
]
},
"namespace": {
"multiple": false,
"required": true,
"types": [
},
{
"type": "interpreted_string_literal",
"named": true
@ -505,20 +465,6 @@
"named": true
}
]
},
"variable": {
"multiple": false,
"required": true,
"types": [
{
"type": "interpreted_string_literal",
"named": true
},
{
"type": "raw_string_literal",
"named": true
}
]
}
}
},

1754
src/parser.c generated

File diff suppressed because it is too large Load diff

View file

@ -40,7 +40,7 @@ foo = select(soong_config_variable("my_namespace", "my_var"), {
(identifier)
(operator)
(select_expression
(soong_config_variable
(select_value
(selection_type)
(interpreted_string_literal)
(interpreted_string_literal))
@ -209,16 +209,14 @@ foo = select(release_variable("ONE", "TWO"), {
(select_expression
(select_value
(selection_type)
(ERROR
(interpreted_string_literal))
(interpreted_string_literal)
(interpreted_string_literal))
(select_cases
(select_case
(interpreted_string_literal)
(interpreted_string_literal))
(select_case
(default)
(interpreted_string_literal))))))
(select_case
(interpreted_string_literal)
(interpreted_string_literal))
(select_case
(default)
(interpreted_string_literal)))))
================================================================================
Select as an identifier