ambroisie/kraken-assessment
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

kraken: csv: fix comma separation logic

Browse source 
Unfortunately, `std::ostream_iterator` puts its separator *after* every
element, not *in-between* each element.
This commit is contained in:
Bruno BELANYI 2022-03-12 00:45:27 +01:00
parent 6ee4e5b554
commit bd072e1025
2 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/csv/write-csv.cc
View file

@ -8,8 +8,12 @@ namespace kraken::csv {
void write_csv(std::ostream& output, csv_type const& csv) { void write_csv(std::ostream& output, csv_type const& csv) {
for (const auto& line : csv) { for (const auto& line : csv) {
std::ranges::copy(line, bool first = true;
std::ostream_iterator<std::string>{output, ","}); for (const auto& atom : line) {
output << (first ? "" : ",") << atom;
first = false;
};
output << '\n';
} }
} }

4
tests/unit/csv.cc
View file

@ -48,7 +48,7 @@ TEST(write_csv, empty) {
ASSERT_EQ(output.str(), expected); ASSERT_EQ(output.str(), expected);
} }
TEST(write_csv, DISABLED_single_line) { TEST(write_csv, single_line) {
auto const csv = csv_type{ auto const csv = csv_type{
{"a", "b", "c"}, {"a", "b", "c"},
}; };
@ -58,7 +58,7 @@ TEST(write_csv, DISABLED_single_line) {
ASSERT_EQ(output.str(), expected); ASSERT_EQ(output.str(), expected);
} }
TEST(write_csv, DISABLED_multiple_lines) { TEST(write_csv, multiple_lines) {
auto const csv = csv_type{ auto const csv = csv_type{
{"a", "b", "c"}, {"a", "b", "c"},
{"1", "2", "3"}, {"1", "2", "3"},