From ef027c77f6475b23cdea91ec8864ab4c70310cee Mon Sep 17 00:00:00 2001 From: Bruno BELANYI Date: Sat, 12 Mar 2022 13:57:21 +0100 Subject: [PATCH] doc: adjust README w/ trade matching --- README.md | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 643ffc9..4a96381 100644 --- a/README.md +++ b/README.md @@ -81,8 +81,13 @@ displays its output as it comes along), etc... #### Matching trades -The only `FIXME` in the code is where I should handle the matching of trades. -Seems like a pretty important feature for a *matching* engine. +The logic used when trade matching is enabled is pretty limited: it wasn't clear +to me what to do when either of the orders have left-over quantities to be +fulfilled. More explicit instructions on this point would lead to the removal of +the final `FIXME`s in the code. + +Related to that point, the matching functionality should be tested further, +rather than just using the two provided examples. #### Cancelling orders