ambroisie/abacus
ambroisie/abacus
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

abacus: bignum: simplify is_canonicalized
All checks were successful
continuous-integration/drone/push Build is passing
Details

Browse source
This commit is contained in:
Bruno BELANYI 2022-02-17 10:13:11 +01:00
parent a382b299b0
commit c9460c09d5
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/bignum/bignum.cc
View file

@ -385,15 +385,15 @@ bool BigNum::is_canonicalized() const {
return sign_ == 0;
}
auto const leading_zeros = std::find_if(digits_.rbegin(), digits_.rend(),
[](auto v) { return v != 0; });
if (leading_zeros != digits_.rbegin()) {
// `back` is valid since there is at least one element
auto const has_leading_zero = digits_.back() == 0;
if (has_leading_zero) {
return false;
}
auto const overflow = std::find_if(digits_.begin(), digits_.end(),
[](auto v) { return v >= BASE; });
if (overflow != digits_.end()) {
auto const has_overflow = std::any_of(digits_.begin(), digits_.end(),
[](auto v) { return v >= BASE; });
if (has_overflow) {
return false;
}