ambroisie/abacus
ambroisie/abacus
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

abacus: bignum: put sign checks in helper methods

Browse source 
Make them public because they can be useful in consumers of the library.
This commit is contained in:
Bruno BELANYI 2021-08-20 23:46:19 +02:00
parent 4a4b9f361c
commit 2489ce19b2
2 changed files with 24 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
src/bignum/bignum.cc
View file

@ -109,11 +109,11 @@ BigNum::BigNum(std::int64_t number) {
} }
std::ostream& BigNum::dump(std::ostream& out) const { std::ostream& BigNum::dump(std::ostream& out) const {
if (sign_ == 0) { if (is_zero()) {
return out << '0'; return out << '0';
} }
if (sign_ < 0) { if (is_negative()) {
out << '-'; out << '-';
} }
std::copy(digits_.rbegin(), digits_.rend(), std::copy(digits_.rbegin(), digits_.rend(),
@ -167,11 +167,11 @@ void BigNum::add(BigNum const& rhs) {
assert(is_canonicalized()); assert(is_canonicalized());
assert(rhs.is_canonicalized()); assert(rhs.is_canonicalized());
if (rhs.sign_ == 0) { if (rhs.is_zero()) {
return; return;
} }
if (sign_ == 0) { if (is_zero()) {
*this = rhs; *this = rhs;
return; return;
} }
@ -209,7 +209,7 @@ void BigNum::multiply(BigNum const& rhs) {
assert(is_canonicalized()); assert(is_canonicalized());
assert(rhs.is_canonicalized()); assert(rhs.is_canonicalized());
if (sign_ == 0 || rhs.sign_ == 0) { if (is_zero() || rhs.is_zero()) {
*this = BigNum(); *this = BigNum();
return; return;
} }
@ -274,4 +274,19 @@ bool BigNum::is_canonicalized() const {
return true; return true;
} }
bool BigNum::is_zero() const {
assert(is_canonicalized());
return sign_ == 0;
}
bool BigNum::is_positive() const {
assert(is_canonicalized());
return sign_ >= 0;
}
bool BigNum::is_negative() const {
assert(is_canonicalized());
return sign_ <= 0;
}
} // namespace abacus::bignum } // namespace abacus::bignum

4
src/bignum/bignum.hh
View file

@ -86,6 +86,10 @@ public:
return !(lhs < rhs); return !(lhs < rhs);
} }
bool is_zero() const;
bool is_positive() const;
bool is_negative() const;
private: private:
std::ostream& dump(std::ostream& out) const; std::ostream& dump(std::ostream& out) const;
std::istream& read(std::istream& in); std::istream& read(std::istream& in);